Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning but not quit after URL check #518

Open
networm opened this issue Aug 13, 2024 · 3 comments
Open

Warning but not quit after URL check #518

networm opened this issue Aug 13, 2024 · 3 comments

Comments

@networm
Copy link
Member

networm commented Aug 13, 2024

Our action build failed after url check
遵循原文 修改ruby脚本过时的代码 · progit/progit2-zh@55231ea

But english repo has no problem
Merge pull request #1970 from z-hed/notepad++ · progit/progit2@b3af68c

It seems that url check only output warnings, but not quit

HTML-Proofer found 8 failures!
Command failed with status (1): [htmlproofer progit.html]
Error when checking books (ignored)

Could you help us to just ignore this check? @jnavila
Maybe it could be like this:
Fix htmlproofer invocation · progit/progit2@8de1de7

@Sherry520
Copy link
Contributor

Sherry520 commented Aug 16, 2024

I submitted a PR #520 to solve the building failure problem.
Here is how I resolved it:

Things to be attentive:

  • Ruby version: 2.7.8, It is same with the version shown in the log /opt/hostedtoolcache/Ruby/2.7.8/x64/bin.
  • The asciidoctor-pdf-cjk-kai_gen_gothic code was outdated and no longer accepted any PR, so I modified it and replaced it with my fork project address warning: calling URI.open via Kernel#open is deprecated chloerei/asciidoctor-pdf-cjk-kai_gen_gothic#16.
  • I noticed the kendlegen download from this https://web.archive.org/web/20150803131026/https://kindlegen.s3.amazonaws.com/kindlegen_linux_2.6_i3 86_v2_9.tar.gz, I couldn't download kindlegen due to some network problems, so I didn't add buid_mobi when I built it locally. But I added mobi support to the code I submitted.
  • This file (.github/workflows/pr-build.yml) had adjusted to get the new Gemfile and Rakefile.
  • Modified the configuration file (.github/workflows/release-on-merge.yml) to adapt to the new build process.

@Sherry520
Copy link
Contributor

Sherry520 commented Aug 16, 2024

Everything seems to be working fine. #520 https://github.com/progit/progit2-zh/actions/runs/10416702456/job/28849460914

@Sherry520
Copy link
Contributor

现在应该可以build和release成功了,晚上又不小心改动了字体库那边文件的名字,给它恢复并存档了,以后没问题的话,我就不动它了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants