Need to reconcile clustering functionalities #1894
jamesmkrieger
started this conversation in
General
Replies: 1 comment
-
Now we also have calcGromosClusters in #1406 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We currently have quite a few of these and it's not clear what the differences between them are. These include:
cluster_col
inshowPerturbResponse
, which does nothing except affect the xlabelcluster
inshowAtomicMatrix
, which likewise does nothingclusterMatrix
in utilities/catchall.py, which reorders a matrix using scipy.cluster.hierarchyreorderMatrix
in utilities/catchall.py, which reorders a matrix using a precalculated treefindSubgroups
in utilities/catchall.py, which finds subgroups from a tree and optionally uses scipy.cluster.hierarchy.fcluster on a linkage matrixclusterSubfamilies
in pull request Added calcModeClusters method to utilities/catchall.py #1098There are probably more too. For example, the function
calcTree
likely has some other redundant relatives.Beta Was this translation helpful? Give feedback.
All reactions