-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate STEP file? #9
Comments
Hi! My fork doesn't currently support it, but this is something I would like to add. I generate STEP files from time to time. I didn't include them in my first approach just because they are huge and testing them is complex. Regards, SET |
@set-soft Thanks for the response! I'm afraid most of this code is outside my wheelhouse, so I likely wouldn't be much help with the initial legwork. I do, however, have your fork up and running with github actions and can help test! @leoheck Sweet! I see you have a kicad-automation repo, but it doesn't look like you've forked off of productize or elsewhere. I'd love to check the code out if you want to push to your repo or make a PR to @set-soft's (if applicable). |
@maholli I do have, but just because I was merging code from all of the forks to make it work fast, for my purposes. |
Hi @leoheck I'll take a look at what's needed to export the STEP files. If you have working code tell me where is and I'll take a look at it. |
I took a look into this. There is no need to add it to these scripts. The "File -> Export -> Step" dialog is just a wrapper for /usr/bin/kicad2step. This functionality could be added to kiplot (my fork uses kicad-automation-scripts) |
Nice My first attempt (and it is working, at least for me) is this If you want to test it you may need my whole folder since it adds other dependencies from other forks. It is not well organized yet |
Thanks @leoheck I'm finishing some details on my fork and then I'll see how to export the step file. |
Totally off-topic question for you @set-soft (where I can talk to you?) Do you have any idea if it is possible to run these tools, on a system without GUI? I want to integrate them into my CI (using GitHub workspaces) So, I can see 2 problems here.
So, the issue I see is that these tools are GUI dependent since they need Windows to do the job. Do you know if there is any way to work around this GUI dependency? Ah, just found this Xvfb to fake a Display. It looks good. |
I'm not sure if I understand, the whole idea is to run them in a server without X and using them for continuous integration. Like in this example: https://github.com/INTI-CMNB/kicad_ci_test also this example: https://gitlab.com/set-soft/kicad-ci-test-spora |
Oh, thank you for this info. This comment relates to this thread. If you are adding a way to export the step file in your repo. A good thing to do is to also test if 3d-models of the parts are good (test if they are not multipart, for instance). Maybe Freecad has something to help here. This is especially helpful when the user adds external 3d-models. When 3d-models are not good, the generated step file (is usable) but a single part is not generated because the boolean operation used to make it fails. |
Ok, added something. @leoheck Do you have examples for the issue you mention? What should we do in this case? Print a warning about it? |
Are you talking about the issues here #9 (comment) ? Maybe they are not issues anymore. You've solved this when you told us that these tools were running on docker/ci. And I verified it by myself running it on my own ci and on my my computer ssh-ing to it without X11. Considering my last comment here... I would just suggest changing this part. I forgot to say it when I was showing the comment before. |
Nope, sorry for not quoting to make it clear, I was talinkg about:
And:
Of course, all the command line options can be controlled. |
Oh ok, I see. I was looking into it, and this looks something hard to do since even KicadStepUp plugin for Freecad not always can't tell the right answer. For instance, when the board uses only the 3d-models coming from the Kicad library the exported part is a single solid since KicadStepUp owner builds the Kicad Library considering this. But if the user, like me, uses models from the internet, to fulfill the missing parts, sometimes these models are not good (as in they can't be used on boolean operations like addition) and Kicad won't export the .step file as a single solid. This "single solid" feature is a good thing to have because when working with MCAD, you can use the explode operation, to visualize the device and system's parts better, and the board won't explode in many thousands of pieces. It will be handled as a single part. So, long story short, this is a good feature to have, but it is hard to implement unless we find something useful here. Also, its result not something really important since the exported .step file can be used normally. I was discussing this with @easyw, here easyw/kicadStepUpMod#50 |
Ok, I understand the idea. If we find a rasonable way to detect I'll add a warning. |
Has anyone played around with auto generating STEP files (File -> Export -> STEP)? Any tips?
@set-soft, maybe your fork is more suitable for this?
The text was updated successfully, but these errors were encountered: