Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Fetch BPMN diagrams in projects instead of bundling them with the JS code #502

Open
8 tasks
tbouffard opened this issue Jun 5, 2023 · 0 comments
Labels
refactoring Code refactoring

Comments

@tbouffard
Copy link
Member

tbouffard commented Jun 5, 2023

Currently. the BPMN diagrams are stored as string within the JS bundles. This increases the size of the bundle and does not reflect what an application generally does: it doesn't store the diagrams that are retrieved from services or API.
This also applies to the upcoming "Vue" example: #501

See also #18 (comment)

⚠️ Warning: remember that the "projects" are often deployed in non root context. This can impact the way diagrams are fetched. See https://github.com/process-analytics/bpmn-visualization-examples/pull/501/files/c764eb211ac34014b1091874635ae22b73c84741#diff-538d08d2ccf3dd8a78b49e615961ebd25870ba4e727a2848fd645d8a80f0cd66

Notes

We also have the same need for demo built in other repositories

Projects to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

No branches or pull requests

1 participant