Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove StartSpan function from tele package #32

Open
iand opened this issue Oct 2, 2023 · 0 comments
Open

Remove StartSpan function from tele package #32

iand opened this issue Oct 2, 2023 · 0 comments

Comments

@iand
Copy link
Contributor

iand commented Oct 2, 2023 •
edited
Loading

Migrated from libp2p/go-libp2p-kad-dht#927

We should remove this function: https://github.com/libp2p/go-libp2p-kad-dht/blob/e86381e824dd2797cf931f14070292fe763a0c93/v2/tele/tele.go#L133

Instead we should plumb a tracer through to the pool/probe/etc.

Context: libp2p/go-libp2p-kad-dht#924 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
DHT Optimization
Status: Planned
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iand