Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsx watch in concurrently hangs on Windows if there are certain modules imports #623

Open
4 of 6 tasks
NadAlaba opened this issue Jul 27, 2024 · 4 comments
Open
4 of 6 tasks
Labels
bug Something isn't working

Comments

@NadAlaba
Copy link

Acknowledgements

  • I read the documentation and searched existing issues to avoid duplicates
  • I understand this is a bug tracker and anything other than a proven bug will be closed
  • I understand this is a free project and relies on community contributions
  • I read and understood the Contribution guide

Minimal reproduction URL

https://github.com/NadAlaba/tsx-issue-repro

Problem & expected behavior (under 200 words)

  • Running tsx watch index.ts inside concurrently on Windows makes tsx watch hang, without running the ts file, if the ts file has references to a suspicious module.
  • Currently discovered suspicious modules are: chalk, prom-client, swagger-stats, googleapis.
  • This issue is almost certainly not a concurrently issue because it happens without concurrently as was discovered on this turbo issue.

Bugs are expected to be fixed by those affected by it

  • I'm interested in working on this issue

Compensating engineering work will speed up resolution and support the project

  • I'm willing to offer $10 for financial support
@NadAlaba NadAlaba added bug Something isn't working pending triage labels Jul 27, 2024
@privatenumber
Copy link
Owner

This issue is almost certainly not a concurrently issue because it happens without concurrently as was discovered on this vercel/turborepo#7834.

Can you remove concurrently from your minimal reproduction then?

Can you also add a GitHub Action that reproduces the bug on Windows? I don't have a Windows

@NadAlaba
Copy link
Author

Can you remove concurrently from your minimal reproduction then?

@privatenumber As far as I can tell this issue requires tsx watch to run through concurrently or turbo in order to happen. I was saying it happened without concurrently, but with turbo on the linked issue.

Can you also add a GitHub Action that reproduces the bug on Windows? I don't have a Windows

Done!

@iuroc
Copy link

iuroc commented Aug 19, 2024

This issue is caused by import/require "process" combined with process.stdin.on("data", ()=>{}).

process.stdin.on('data', () => reRun('Return key'));

You can add the -r option to concurrently to resolve it.

Disabling OnReturnKey can also solve the issue.

I have submitted a PR (#639) that allows you to manually disable OnReturnKey by using --on-return-key=false.

@lord007tn

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants