From 3aadc2d913b8dec3b77a7e94636fcf06a37f42c2 Mon Sep 17 00:00:00 2001 From: Ivar Derksen Date: Fri, 1 Sep 2023 15:36:58 +0200 Subject: [PATCH 1/3] Chore: remove leftover TODOs --- internal/keysharecore/operations_test.go | 1 - server/keyshare/keyshareserver/server.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/keysharecore/operations_test.go b/internal/keysharecore/operations_test.go index 825dceff5..04e50e02c 100644 --- a/internal/keysharecore/operations_test.go +++ b/internal/keysharecore/operations_test.go @@ -183,7 +183,6 @@ func TestProofFunctionality(t *testing.T) { require.NoError(t, err) // For issuance, initially get P_t - // TODO: The result ps will be used in the generate commitment step and checked when the response is made. _, err = c.GeneratePs(secrets, jwtt, []irma.PublicKeyIdentifier{irma.PublicKeyIdentifier{Issuer: irma.NewIssuerIdentifier("test"), Counter: 1}}) require.NoError(t, err) diff --git a/server/keyshare/keyshareserver/server.go b/server/keyshare/keyshareserver/server.go index 9fc75a000..9af977ac3 100644 --- a/server/keyshare/keyshareserver/server.go +++ b/server/keyshare/keyshareserver/server.go @@ -315,7 +315,6 @@ func (s *Server) handleCommitmentsV2(w http.ResponseWriter, r *http.Request) { } commitments, err := s.generateCommitmentsV2(user, authorization, req) - // TODO: can ErrInvalidChallenge be removed? if err != nil && (err == keysharecore.ErrInvalidChallenge || err == keysharecore.ErrInvalidJWT) { server.WriteError(w, server.ErrorInvalidRequest, err.Error()) return @@ -338,7 +337,6 @@ func (s *Server) generateCommitmentsV2(user *User, authorization string, req irm } // Prepare output message format - // TODO: move logic to gabi? mappedCommitments := map[irma.PublicKeyIdentifier]*big.Int{} for i, keyID := range req.Keys { mappedCommitments[keyID] = commitments[i].Pcommit From 926dd06c7df4837cf7c764e45bd29549126754ad Mon Sep 17 00:00:00 2001 From: Ivar Derksen Date: Fri, 1 Sep 2023 15:49:00 +0200 Subject: [PATCH 2/3] Chore: updated changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 75faaa0c4..b8d504bc6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +## Added +- Keyshare server /api/v2/prove/... endpoints for the new keyshare protocol + ### Added - E-mail address revalidation, addressing issues where user's e-mail addresses can be (temporary) invalid From a26449accf42e1a8af81eb69accd7d937375dac1 Mon Sep 17 00:00:00 2001 From: Ivar Derksen Date: Fri, 1 Sep 2023 16:42:29 +0200 Subject: [PATCH 3/3] Chore: fix duplicate headers in changelog --- CHANGELOG.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b8d504bc6..c8ec8773d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,12 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## Unreleased - -## Added -- Keyshare server /api/v2/prove/... endpoints for the new keyshare protocol - ### Added - E-mail address revalidation, addressing issues where user's e-mail addresses can be (temporary) invalid +- Keyshare server /api/v2/prove/... endpoints for the new keyshare protocol ### Changed - Use separate application user in Dockerfile for entrypoint