Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application not fully stateless #31

Open
ivard opened this issue Nov 22, 2024 · 0 comments
Open

Application not fully stateless #31

ivard opened this issue Nov 22, 2024 · 0 comments

Comments

@ivard
Copy link
Member

ivard commented Nov 22, 2024

The application stores the tokens it sends by SMS in memory. This means that the application cannot be replicated at the moment for high availability. In a Kubernetes setup, this application can restart at any moment. This means that the application state gets lost then and SMS message sent out just before the restart are not valid anymore.

private final Map<String, TokenRequest> tokenMap;

This application has some rate limiting built-in to prevent that attackers can send a very large amount of SMS messages to a single user. This rate limiting is currently also done in memory. This should also be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant