Hide Circuit implementation of sub-circuits behind test feature

[han0110]

After #937 we no longer need the implementation Circuit for sub-circuits in production, it's only required for test and crates circuit-benchmarks to benchmark individual sub-circuit, so we should move current implementation into #[cfg(any(feature = "test", test))] mod test { ... } to avoid further consumers to use them accidentally.

[CPerezz]

I'm totally in favor of that change!

[SuccinctPaul]

Hi, I can do it.

[CPerezz]

NOTE that circuit-benchmarks will need to import zkevm-circuits with test feature!

Assigning to @ChengYueJia then!

[SuccinctPaul]

@CPerezz @han0110
You can have a view #1003

[leolara]

@han0110 @ChengYueJia Doesn't SuperCircuit get used outside the tests to run the actual system?

[han0110]

Yes, SuperCircuit used as Circuit in zkevm-chain, so we should keep its impl, sorry I didn't mention that in the issue.

[leolara]

But then, my question is SuperCircuit uses the Circuit implementation of the other SubCircuits:

https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/main/zkevm-circuits/src/super_circuit.rs#L269-L276

so all these, should not be only in the tests, but also in production, right?

[han0110]

But new_from_block is method of SubCircuit, which doesn't require the struct to implement Circuit, or is there anything inside these implementation requires Circuit implementation?

[ed255]

Resolved via #1300