verifyProof probably should return false for any key if the tree is empty

[0xDatapunk]

zk-kit/packages/smt/src/smt.ts

Line 237 in 253277c

verifyProof(merkleProof: MerkleProof): boolean {

not sure if it is as designed, but verifyProof return True for any key with an empty tree. It makes better sense if false is returned:

verifyProof(merkleProof: MerkleProof): boolean {
    if (this.root === this.zeroNode) {
        // Empty tree case
        return merkleProof.root === this.zeroNode && 
               merkleProof.siblings.length === 0 &&
               merkleProof.matchingEntry === undefined &&
               merkleProof.membership === false;
    }
    // ... rest of the method ...
}```

[cedoor]

A proof of non-membership in a empty tree should still be true tho. Wdyt @0xDatapunk ?

[0xDatapunk]

yes, and the code above should return true for non-membership.

[cedoor]

Not sure about this merkleProof.matchingEntry === undefined -> should a matchingEntry should still be defined?