From 4b72870608e9b8e5647b876c08b224dee53c1783 Mon Sep 17 00:00:00 2001 From: sripwoud Date: Thu, 8 Aug 2024 13:39:37 +0200 Subject: [PATCH] ci: checkout before reporting coverage to coveralls (#47) I had deliberately ommitted the checkout step in the coverage job in #46 because I thought it was sufficient for `coveralls` to only have a coverage report file (`lcov.info`) in order to be able to report the coverage. But it is not, it needs to read the src files too, otherwise it fails with a [`nothing to report` error](https://github.com/privacy-scaling-explorations/zk-kit.rust/actions/runs/10300402250/job/28509727109#step:3:60). So we need to checkout. The [coverage job execution on this test branch](https://github.com/privacy-scaling-explorations/zk-kit.rust/actions/runs/10301338228/job/28512666893?pr=48#step:4:62) demonstrated that the fix is effective. --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 59e39f3..20ff260 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -58,6 +58,7 @@ jobs: if: github.event_name == 'push' && github.ref == 'refs/heads/main' runs-on: ubuntu-latest steps: + - uses: actions/checkout@v4 - uses: actions/download-artifact@v4 with: name: lcov.info