Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): payout strategy #353

Merged
merged 1 commit into from
Oct 29, 2024
Merged

feat(contracts): payout strategy #353

merged 1 commit into from
Oct 29, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Sep 23, 2024

  • Use tally as payout strategy
  • Add deposit/claim/withdraw functions
  • Add tests
  • Add pause for tally in poll deploy script
  • Update deploy config
  • Add tally initialization
  • Add batch method for rewards calculation

Next things to do:

  1. Subgraph integration

Related to #263

@0xmad 0xmad added the enhancement New feature or request label Sep 23, 2024
@0xmad 0xmad self-assigned this Sep 23, 2024
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 7:18pm

@0xmad 0xmad force-pushed the feature/payout-strategy branch from 2386826 to 105f96b Compare September 23, 2024 20:22
@0xmad 0xmad force-pushed the feature/payout-strategy branch from f8b6297 to fa08127 Compare September 26, 2024 20:13
packages/contracts/contracts/maci/Tally.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/maci/Tally.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/maci/Tally.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/maci/Tally.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/maci/Tally.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/maci/Tally.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/maci/Tally.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/maci/Tally.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/maci/Tally.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/maci/Tally.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/maci/Tally.sol Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! just one comment but otherwise lgtm

packages/contracts/contracts/maci/Tally.sol Show resolved Hide resolved
- [x] Use tally as payout strategy
- [x] Add deposit/claim/withdraw functions
- [x] Add tests
- [x] Add pause for tally in poll deploy script
- [x] Update deploy config
- [x] Add tally initialization
- [x] Add batch method for rewards calculation
@0xmad 0xmad force-pushed the feature/payout-strategy branch from 04d8285 to 9c5a4ca Compare October 29, 2024 19:12
@0xmad 0xmad enabled auto-merge October 29, 2024 19:12
@0xmad 0xmad merged commit 4e1a3a5 into main Oct 29, 2024
16 checks passed
@0xmad 0xmad deleted the feature/payout-strategy branch October 29, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants