Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: collect metadata from console and upload #352

Merged
merged 1 commit into from
Oct 3, 2024
Merged

feat: collect metadata from console and upload #352

merged 1 commit into from
Oct 3, 2024

Conversation

kittybest
Copy link
Contributor

Description

  • collect round information from the console, upload the information as a json file to the vercel blob storage
  • print the url of that json file for user to put inside the deploy-config.json file
  • add metadataUrl on the subgraph schema for the frontend to fetch

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 3:55pm

@kittybest kittybest marked this pull request as ready for review September 24, 2024 16:39
0xmad
0xmad requested changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, just some changes requested

packages/coordinator/package.json Outdated Show resolved Hide resolved
packages/coordinator/scripts/uploadRoundMetadata.ts Outdated Show resolved Hide resolved
@kittybest kittybest force-pushed the feat/upload-metadata branch from b026c30 to 70c6194 Compare October 2, 2024 16:26
@kittybest kittybest force-pushed the feat/upload-metadata branch 2 times, most recently from fa5967c to 2488dab Compare October 2, 2024 16:54
@kittybest kittybest force-pushed the feat/upload-metadata branch from 2488dab to 2112da7 Compare October 2, 2024 17:33
@kittybest kittybest force-pushed the feat/upload-metadata branch from 2112da7 to 9253cd9 Compare October 3, 2024 08:30
@kittybest kittybest force-pushed the feat/upload-metadata branch from 9253cd9 to 4eb320e Compare October 3, 2024 09:03
@kittybest kittybest force-pushed the feat/upload-metadata branch from 4eb320e to 9353106 Compare October 3, 2024 09:16
@kittybest kittybest force-pushed the feat/upload-metadata branch from 9353106 to d1626d0 Compare October 3, 2024 15:50
0xmad
0xmad approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks!

packages/subgraph/templates/subgraph.template.yaml Show resolved Hide resolved
@kittybest kittybest merged commit b096591 into main Oct 3, 2024
16 checks passed
@kittybest kittybest deleted the feat/upload-metadata branch October 3, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 left review comments

@0xmad 0xmad 0xmad approved these changes

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittybest @0xmad @ctrlc03