Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement project search in registries branch #412

Open
ctrlc03 opened this issue Oct 23, 2024 · 3 comments · May be fixed by #533
Open

Implement project search in registries branch #412

ctrlc03 opened this issue Oct 23, 2024 · 3 comments · May be fixed by #533
Assignees

Comments

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Oct 23, 2024

Due to the projects/applications names coming from a metadata file, this data is not readily available for filter in trpc queries. Thus, some reworking is needed to be able to search proejcts/applications by name (or also sort them)

branch/pr: #407

@ctrlc03 ctrlc03 added this to MACI Oct 23, 2024
@NicoSerranoP NicoSerranoP self-assigned this Oct 31, 2024
@aguzmant103
Copy link
Member

aguzmant103 commented Nov 28, 2024

@NicoSerranoP are you working on this issue? I have the following questions if so:

  • Can you update the status?
  • Any ETA?
  • Need any design support?

@NicoSerranoP
Copy link
Member

Hi @aguzmant103 😊 I am working on it at the moment, I have some updates:

  1. The projects object is coming from a Subgraph TRPC query that returns an object that contains pages which contain projects (for performance purposes). I am trying to insert the metadata values in the project object to use the return list in all places where we are currently using the projects variable but I am having some issues.

  2. We explored the idea of adding the name to a smart contract event so that Subgraph would save that and make it easy to filter. The problem with this approach is that if in the future we want to filter by any other attribute, we will have to add it to the event as well (it is not efficient in the long term)

ETA: I think that between tomorrow and Monday it will be completed 🫡

Design: I do not think we need design support because we are reusing the existing Projects interface

@aguzmant103
Copy link
Member

Amazing, thanks man! :) @NicoSerranoP

@aguzmant103 aguzmant103 moved this to Todo in MACI Platform Dec 4, 2024
@aguzmant103 aguzmant103 linked a pull request Dec 10, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants