Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(interface): prevent negative countdown timer #284

Closed
kittybest opened this issue Aug 28, 2024 · 3 comments
Closed

Bug(interface): prevent negative countdown timer #284

kittybest opened this issue Aug 28, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kittybest
Copy link
Contributor

Description
When voting period is over the timer is negative, should move to the next period --> check why it's not moving to the Tallying status.

@kittybest kittybest added the bug Something isn't working label Aug 28, 2024
@kittybest kittybest self-assigned this Aug 28, 2024
@kittybest kittybest added this to MACI Aug 28, 2024
@ctrlc03
Copy link
Collaborator

ctrlc03 commented Aug 30, 2024

@kittybest maybe here https://github.com/privacy-scaling-explorations/maci-platform/blob/main/packages/interface/src/components/VotingInfo.tsx#L21-L23 we need to add

  {!isLoading && timeLeft[3] < 0 && <p>Voting has ended</p>}

?

@kittybest
Copy link
Contributor Author

@kittybest maybe here https://github.com/privacy-scaling-explorations/maci-platform/blob/main/packages/interface/src/components/VotingInfo.tsx#L21-L23 we need to add

  {!isLoading && timeLeft[3] < 0 && <p>Voting has ended</p>}

?

I'm just thinking about if the timeLeft < 0, the state should be moved to Tally? So actually this shouldn't happen. But it's a efficient way to prevent negative timer displayed.

@kittybest
Copy link
Contributor Author

close by #290

@github-project-automation github-project-automation bot moved this to Done in MACI Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants
@kittybest @ctrlc03 and others