Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include shuffle within transcript when empty prior to a new major version release #227

Closed
CPerezz opened this issue Nov 10, 2023 · 2 comments · Fixed by #348
Closed

Include shuffle within transcript when empty prior to a new major version release #227

CPerezz opened this issue Nov 10, 2023 · 2 comments · Fixed by #348
Labels
breaking-change Changes that will break the current API

Comments

@CPerezz
Copy link
Member

CPerezz commented Nov 10, 2023

Just realized the change might lead to different transcript_repr even the circuit doesn't use shuffle, so I think to keep backward compatability we need to skip the shuffle field when it's empty.

Originally posted by @han0110 in #195 (comment)

@davidnevadoc
Copy link

davidnevadoc commented Nov 14, 2023

Doesn't the comment say the opposite? @CPerezz

@CPerezz
Copy link
Member Author

CPerezz commented Nov 17, 2023

Doesn't the comment say the opposite? @CPerezz

That's why I say "prior to a new major release". By that I mean that we can just assume we break backwards compatibility with a new major version release.
Hence we don't care more about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes that will break the current API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants