Reimplement keygen_vk for fe-be split as keygen_vk_v2 #247
GitHub Actions / Clippy (beta)
succeeded
Dec 13, 2023 in 0s
Clippy (beta)
4 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 4 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.66.0 (69f9c33d7 2022-12-12)
- cargo 1.66.0 (d65d197ad 2022-11-15)
- clippy 0.1.66 (69f9c33 2022-12-12)
Annotations
Check warning on line 1569 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (beta)
multiple fields are never read
warning: multiple fields are never read
--> halo2_proofs/src/plonk/circuit.rs:1569:16
|
1568 | pub struct ConstraintSystemV2Backend<F: Field> {
| ------------------------- fields in this struct
1569 | pub(crate) num_fixed_columns: usize,
| ^^^^^^^^^^^^^^^^^
1570 | pub(crate) num_advice_columns: usize,
| ^^^^^^^^^^^^^^^^^^
1571 | pub(crate) num_instance_columns: usize,
| ^^^^^^^^^^^^^^^^^^^^
1572 | // pub(crate) num_selectors: usize,
1573 | pub(crate) num_challenges: usize,
| ^^^^^^^^^^^^^^
...
1576 | pub(crate) unblinded_advice_columns: Vec<usize>,
| ^^^^^^^^^^^^^^^^^^^^^^^^
...
1579 | pub(crate) advice_column_phase: Vec<sealed::Phase>,
| ^^^^^^^^^^^^^^^^^^^
1580 | /// Contains the phase for each challenge. Should have same length as num_challenges.
1581 | pub(crate) challenge_phase: Vec<sealed::Phase>,
| ^^^^^^^^^^^^^^^
...
1608 | pub(crate) general_column_annotations: HashMap<metadata::Column, String>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `ConstraintSystemV2Backend` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
Check warning on line 50 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
fields `domain`, `fixed_commitments`, `permutation`, `cs` and `cs_degree` are never read
warning: fields `domain`, `fixed_commitments`, `permutation`, `cs` and `cs_degree` are never read
--> halo2_proofs/src/plonk.rs:50:5
|
49 | pub struct VerifyingKeyV2<C: CurveAffine> {
| -------------- fields in this struct
50 | domain: EvaluationDomain<C::Scalar>,
| ^^^^^^
51 | fixed_commitments: Vec<C>,
| ^^^^^^^^^^^^^^^^^
52 | permutation: permutation::VerifyingKey<C>,
| ^^^^^^^^^^^
53 | cs: ConstraintSystemV2Backend<C::Scalar>,
| ^^
54 | /// Cached maximum degree of `cs` (which doesn't change after construction).
55 | cs_degree: usize,
| ^^^^^^^^^
|
= note: `VerifyingKeyV2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Check warning on line 1569 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (beta)
multiple fields are never read
warning: multiple fields are never read
--> halo2_proofs/src/plonk/circuit.rs:1569:16
|
1568 | pub struct ConstraintSystemV2Backend<F: Field> {
| ------------------------- fields in this struct
1569 | pub(crate) num_fixed_columns: usize,
| ^^^^^^^^^^^^^^^^^
1570 | pub(crate) num_advice_columns: usize,
| ^^^^^^^^^^^^^^^^^^
1571 | pub(crate) num_instance_columns: usize,
| ^^^^^^^^^^^^^^^^^^^^
1572 | // pub(crate) num_selectors: usize,
1573 | pub(crate) num_challenges: usize,
| ^^^^^^^^^^^^^^
...
1576 | pub(crate) unblinded_advice_columns: Vec<usize>,
| ^^^^^^^^^^^^^^^^^^^^^^^^
...
1579 | pub(crate) advice_column_phase: Vec<sealed::Phase>,
| ^^^^^^^^^^^^^^^^^^^
1580 | /// Contains the phase for each challenge. Should have same length as num_challenges.
1581 | pub(crate) challenge_phase: Vec<sealed::Phase>,
| ^^^^^^^^^^^^^^^
...
1608 | pub(crate) general_column_annotations: HashMap<metadata::Column, String>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `ConstraintSystemV2Backend` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
Check warning on line 50 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
fields `domain`, `fixed_commitments`, `permutation`, `cs` and `cs_degree` are never read
warning: fields `domain`, `fixed_commitments`, `permutation`, `cs` and `cs_degree` are never read
--> halo2_proofs/src/plonk.rs:50:5
|
49 | pub struct VerifyingKeyV2<C: CurveAffine> {
| -------------- fields in this struct
50 | domain: EvaluationDomain<C::Scalar>,
| ^^^^^^
51 | fixed_commitments: Vec<C>,
| ^^^^^^^^^^^^^^^^^
52 | permutation: permutation::VerifyingKey<C>,
| ^^^^^^^^^^^
53 | cs: ConstraintSystemV2Backend<C::Scalar>,
| ^^
54 | /// Cached maximum degree of `cs` (which doesn't change after construction).
55 | cs_degree: usize,
| ^^^^^^^^^
|
= note: `VerifyingKeyV2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Loading