chore: clippy fixes + tests for zero-length encoding of varlen columns #459
clippy
7 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 7 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.78.0 (9b00956e5 2024-04-29)
- cargo 1.78.0 (54d8815d0 2024-03-26)
- clippy 0.1.78 (9b00956 2024-04-29)
Annotations
Check warning on line 83 in src/tds/xml.rs
github-actions / clippy
direct implementation of `ToString`
warning: direct implementation of `ToString`
--> src/tds/xml.rs:79:1
|
79 | / impl ToString for XmlData {
80 | | fn to_string(&self) -> String {
81 | | self.data.to_string()
82 | | }
83 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `#[warn(clippy::to_string_trait_impl)]` on by default
Check warning on line 30 in src/tds/time.rs
github-actions / clippy
module has the same name as its containing module
warning: module has the same name as its containing module
--> src/tds/time.rs:30:1
|
30 | pub mod time;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
Check warning on line 159 in src/sql_read_bytes.rs
github-actions / clippy
methods `debug_buffer`, `read_i8`, `read_f32`, `read_f64`, `read_u128_le`, and `read_i128_le` are never used
warning: methods `debug_buffer`, `read_i8`, `read_f32`, `read_f64`, `read_u128_le`, and `read_i128_le` are never used
--> src/sql_read_bytes.rs:159:8
|
157 | pub(crate) trait SqlReadBytes: AsyncRead + Unpin {
| ------------ methods in this trait
158 | // Pretty-print current wire content.
159 | fn debug_buffer(&self);
| ^^^^^^^^^^^^
...
168 | fn read_i8(&mut self) -> ReadI8<&mut Self>
| ^^^^^^^
...
192 | fn read_f32(&mut self) -> ReadF32<&mut Self>
| ^^^^^^^^
...
200 | fn read_f64(&mut self) -> ReadF64<&mut Self>
| ^^^^^^^^
...
248 | fn read_u128_le(&mut self) -> ReadU128Le<&mut Self>
| ^^^^^^^^^^^^
...
280 | fn read_i128_le(&mut self) -> ReadI128Le<&mut Self>
| ^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 94 in src/tds/time/chrono.rs
github-actions / clippy
use of deprecated associated function `chrono::DateTime::<Tz>::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead
warning: use of deprecated associated function `chrono::DateTime::<Tz>::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead
--> src/tds/time/chrono.rs:94:27
|
94 | chrono::DateTime::from_utc(naive, offset)
| ^^^^^^^^
Check warning on line 94 in src/tds/time/chrono.rs
github-actions / clippy
use of deprecated associated function `chrono::DateTime::<Tz>::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead
warning: use of deprecated associated function `chrono::DateTime::<Tz>::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead
--> src/tds/time/chrono.rs:94:27
|
94 | chrono::DateTime::from_utc(naive, offset)
| ^^^^^^^^
Check warning on line 84 in src/tds/time/chrono.rs
github-actions / clippy
use of deprecated associated function `chrono::DateTime::<Tz>::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead
warning: use of deprecated associated function `chrono::DateTime::<Tz>::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead
--> src/tds/time/chrono.rs:84:31
|
84 | chrono::DateTime::from_utc(naive, Utc)
| ^^^^^^^^
Check warning on line 84 in src/tds/time/chrono.rs
github-actions / clippy
use of deprecated associated function `chrono::DateTime::<Tz>::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead
warning: use of deprecated associated function `chrono::DateTime::<Tz>::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead
--> src/tds/time/chrono.rs:84:31
|
84 | chrono::DateTime::from_utc(naive, Utc)
| ^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default