From e4f2bca472c50c4efbe3e9ddead4a96e857126e2 Mon Sep 17 00:00:00 2001
From: Miguel Fernandez <miguel@mff.io>
Date: Wed, 22 Nov 2023 16:16:59 +0100
Subject: [PATCH] Explicit exclusion instead of inheriting from mod

---
 .../queries/filters/field_reference/json_filter.rs |  4 ++--
 .../tests/queries/filters/json_filters.rs          | 14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/field_reference/json_filter.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/field_reference/json_filter.rs
index 5c70ad31574e..b865731161c2 100644
--- a/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/field_reference/json_filter.rs
+++ b/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/field_reference/json_filter.rs
@@ -126,7 +126,7 @@ mod json_filter {
         Ok(())
     }
 
-    #[connector_test(schema(schema), exclude(Vitess("planetscale.js")))]
+    #[connector_test(schema(schema), exclude(MySQL(5.6), Vitess("planetscale.js")))]
     async fn string_comparison_filters(runner: Runner) -> TestResult<()> {
         test_string_data(&runner).await?;
 
@@ -169,7 +169,7 @@ mod json_filter {
         Ok(())
     }
 
-    #[connector_test(schema(schema), exclude(Vitess("planetscale.js")))]
+    #[connector_test(schema(schema), exclude(MySQL(5.6), Vitess("planetscale.js")))]
     async fn array_comparison_filters(runner: Runner) -> TestResult<()> {
         test_array_data(&runner).await?;
 
diff --git a/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/json_filters.rs b/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/json_filters.rs
index 851180ffc629..e2ab83cfd62f 100644
--- a/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/json_filters.rs
+++ b/query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/json_filters.rs
@@ -27,7 +27,7 @@ mod json_filters {
         schema.to_owned()
     }
 
-    #[connector_test(exclude(Vitess("planetscale.js")))]
+    #[connector_test(exclude(MySQL(5.6), Vitess("planetscale.js")))]
     async fn no_path_without_filter(runner: Runner) -> TestResult<()> {
         assert_error!(
             runner,
@@ -262,7 +262,7 @@ mod json_filters {
         Ok(())
     }
 
-    #[connector_test(exclude(Vitess("planetscale.js")))]
+    #[connector_test(exclude(MySQL(5.6), Vitess("planetscale.js")))]
     async fn array_contains(runner: Runner) -> TestResult<()> {
         array_contains_runner(runner).await?;
 
@@ -371,7 +371,7 @@ mod json_filters {
         Ok(())
     }
 
-    #[connector_test(exclude(Vitess("planetscale.js")))]
+    #[connector_test(exclude(MySQL(5.6), Vitess("planetscale.js")))]
     async fn array_starts_with(runner: Runner) -> TestResult<()> {
         array_starts_with_runner(runner).await?;
 
@@ -478,7 +478,7 @@ mod json_filters {
         Ok(())
     }
 
-    #[connector_test(exclude(Vitess("planetscale.js")))]
+    #[connector_test(exclude(MySQL(5.6), Vitess("planetscale.js")))]
     async fn array_ends_with(runner: Runner) -> TestResult<()> {
         array_ends_with_runner(runner).await?;
 
@@ -517,7 +517,7 @@ mod json_filters {
         Ok(())
     }
 
-    #[connector_test(exclude(Vitess("planetscale.js")))]
+    #[connector_test(exclude(MySQL(5.6), Vitess("planetscale.js")))]
     async fn string_contains(runner: Runner) -> TestResult<()> {
         string_contains_runner(runner).await?;
 
@@ -557,7 +557,7 @@ mod json_filters {
         Ok(())
     }
 
-    #[connector_test(exclude(Vitess("planetscale.js")))]
+    #[connector_test(exclude(MySQL(5.6), Vitess("planetscale.js")))]
     async fn string_starts_with(runner: Runner) -> TestResult<()> {
         string_starts_with_runner(runner).await?;
 
@@ -596,7 +596,7 @@ mod json_filters {
         Ok(())
     }
 
-    #[connector_test(exclude(Vitess("planetscale.js")))]
+    #[connector_test(exclude(MySQL(5.6), Vitess("planetscale.js")))]
     async fn string_ends_with(runner: Runner) -> TestResult<()> {
         string_ends_with_runner(runner).await?;