ci: Simplify detect_jobs_to_run output (and related if)
#4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original approach of making it fully dynamic does not work because of https://docs.github.com/en/actions/learn-github-actions/contexts#github-context:~:text=the%20current%20job.-,Note%3A%20This%20context%20property%20is%20set%20by%20the%20Actions%20runner%2C%20and%20is%20only%20available%20within%20the%20execution%20steps%20of%20a%20job.%20Otherwise%2C%20the%20value%20of%20this%20property%20will%20be%20null.,-github.path
|
janpio
commented
Nov 26, 2023
janpio
commented
Nov 26, 2023
janpio
commented
Nov 26, 2023
janpio
commented
Nov 26, 2023
janpio
commented
Nov 26, 2023
janpio
changed the title
if for detect_jobs_to_run result
janpio
changed the title
if for detect_jobs_to_run resultdetect_jobs_to_run output (and related if)
|
Note: I was curious to check and everything looks good in this PR #4315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the object was always a bit awkward, so I changed it to just write an array of the needed jobs instead of all jobs with true/false. I think that simplified the
ifa bit.