Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Remove usage of nick-invision/retry #3676

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Conversation

janpio
Copy link
Contributor

@janpio janpio commented Jul 10, 2023

Removes the retry action, keeps the timeouts.

@janpio

This comment was marked as outdated.

@janpio janpio marked this pull request as ready for review May 16, 2024 13:05
@janpio janpio requested review from Jolg42, SevInf and jkomyno as code owners May 16, 2024 13:05
@Jolg42 Jolg42 added this to the 5.15.0 milestone May 16, 2024
@janpio janpio marked this pull request as draft May 16, 2024 13:32
@janpio
Copy link
Contributor Author

janpio commented May 16, 2024

Just saw that it did not actually run the full test suite, that is not a good sign.

@Jolg42
Copy link
Contributor

Jolg42 commented May 16, 2024

@janpio indeed

Invalid workflow file: .github/workflows/test.yaml#L1501
The workflow is not valid. .github/workflows/test.yaml (Line: 1501, Col: 9): Unexpected value 'timeout_minutes' .github/workflows/test.yaml (Line: 1518, Col: 9): Unexpected value 'timeout_minutes'

https://github.com/prisma/ecosystem-tests/actions/runs/9112289021

From https://github.com/prisma/ecosystem-tests/actions?query=branch%3Ajanpio%2Fno-retry

.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
@janpio
Copy link
Contributor Author

janpio commented May 16, 2024

Seems we rely on the retry still:
image

@Jolg42
Copy link
Contributor

Jolg42 commented May 17, 2024

@janpio I think that most failures, in general, are caused in deployments which are shared between library and binary testing.

@Jolg42
Copy link
Contributor

Jolg42 commented May 17, 2024

We could start by keeping the retries in .github/workflows/test.yaml and remove them in other files maybe.

@janpio janpio removed this from the 5.15.0 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants