Astropy and xarray fixes #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-b-yang
approved these changes
Jul 18, 2024
|
Sweet, thanks so much @aorwall! Appreciate the fixes, this is very helpful! I just ran validation of the gold patches with these fixes and the original dependency issues that were popping up with the main branch code do look to be resolved. |
sreekarmolakalapalli
pushed a commit
to Modelcode-ai/SWE-bench
that referenced
this pull request
Aug 14, 2024
Astropy and xarray fixes
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See also #167
What does this implement/fix? Explain your changes.
Docker builds for
astropy/astropy 1.3andpydata/xarray 0.12have stopped working, probably due to unpinned updated dependencies.For
astropy/astropy, I ran a script to see which versions were used at the time of the environment commit and used those. This seems to have made the tests more stable overall since now all tests pass when some, not marked as PASS_TO_PASS or FAIL_TO_PASS, didn't before. Compare this log with the current dependencies and this log where the changed dependencies where used.pydata/xarray 0.12fails becausedask.dataframeisn't found, I added a explicit dependency todask==2022.8.1to fix this.