Download images alongside site files #16
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +58,7 @@ | |||
|
|
|||
| async function download_site() { | |||
| loading = true | |||
| const files = await build_site_bundle({ pages: $pages, symbols: $symbols }) | |||
| const files = await build_site_bundle({ pages: $pages, symbols: $symbols }, true) | |||
There was a problem hiding this comment.
Does this mean it will always download the assets? A checkbox next to the download button would allow both options, with or without images.
|
|
||
| const updated_content = _.mapValues(content, (lang_value) => | ||
| _.mapValues(lang_value, (field_value) => { | ||
| if (typeof field_value === 'object' && field_value.hasOwnProperty('alt')) { |
There was a problem hiding this comment.
Maybe this should check that field_value.url is not empty, i was getting errors when downloading the site
| // Download images | ||
| const image_files = [] | ||
| await Promise.all( | ||
| files_to_fetch.map(async ({ url, filename }) => { |
There was a problem hiding this comment.
this could be in a try catch since fetch can try to download forbidden assets, i have stumbled with this because i have some content with bad remote urls that can not be downloaded because of cors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to merge yet - right now it downloads images in the page sections and swaps out their URLs with the relative image url.
To do
Nice to have