Prevent hidden inputs from taking up space on the page #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d79e411 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
requested review from
mperrotti and
jonrohan
and removed request for
mperrotti
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes an issue where hidden inputs created with the forms framework would take up vertical/horizontal space on the page. Depending on the form, this can lead to weird visual spacing issues. This has been a problem for a while, but was recently exacerbated by #3087 (merged as #3159).
Screenshots
This is difficult to show in a screenshot because the input itself is not visible.
Integration
No changes necessary in production.
List the issues that this change affects.
Fixes #3194
Risk Assessment
What approach did you choose and why?
All inputs are wrapped in the
Groupcomponent, so I added some logic that addsdisplay: noneto groups that contain only hidden inputs.Accessibility
Merge checklist
- [ ] Added/updated documentationTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.