Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draggable divider in resizable PageLayout component should be more obvious #5124

Open
dylanatsmith opened this issue Oct 15, 2024 · 5 comments
Assignees
Labels
product area: copilot This change would support work happening on the Copilot product react size: pebble

Comments

@dylanatsmith
Copy link
Contributor

We got feedback that it’s not clear the PageLayout panes can be resized, and it’s not clear where you would drag to resize. See https://github.com/github/codespaces/issues/19538

I’m proposing a simple solution like adding a grabber icon atop the divider as an affordance:

Image

Since the divider already has good visual hover and active states, maybe the icon is hidden in those states so we don’t need to handle them.

Copy link
Contributor

Uh oh! @dylanatsmith, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@mperrotti
Copy link
Contributor

We discussed this in today's Primer patterns working session and the designers on the call liked @dylanatsmith 's proposal to add a grabber icon atop the divider as an affordance.

@lesliecdubs lesliecdubs added product area: copilot This change would support work happening on the Copilot product and removed enhancement New feature or request component: PageLayout labels Oct 21, 2024
@francinelucca francinelucca self-assigned this Oct 30, 2024
@francinelucca
Copy link
Member

Won't have time to get to this in the immediate future, putting back in the queue

@francinelucca francinelucca removed their assignment Nov 18, 2024
@Adarsha186
Copy link

Hi @dylanatsmith , I am looking for some open source projects to work on. If this is issue is still open and hasn't been resolved, I'm interested in contributing to this issue.

@francinelucca
Copy link
Member

@Adarsha186 assigned you to the issue, let me know if you have any questions on the requirements or our contribution process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product area: copilot This change would support work happening on the Copilot product react size: pebble
Projects
None yet
Development

No branches or pull requests

6 participants