Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prism crashes in Safari due to corrupt color list #70

Open
Myndex opened this issue Sep 20, 2023 · 2 comments
Open

Prism crashes in Safari due to corrupt color list #70

Myndex opened this issue Sep 20, 2023 · 2 comments
Labels
bug Something isn't working needs more info react

Comments

@Myndex
Copy link

Myndex commented Sep 20, 2023

Describe the bug

App crashes in Safari:

https://primer.style/prism/local/81680851-365b-4cc2-89f0-4a5856b07bda/scale/7b1f34cc-d9d9-4c03-84f3-208bc962b7f8

To Reproduce
Steps to reproduce the behavior:

Using Safari (15.6.1) go here:

https://primer.style/prism/local/81680851-365b-4cc2-89f0-4a5856b07bda/scale/7b1f34cc-d9d9-4c03-84f3-208bc962b7f8

It won't load, white screen of death

Expected behavior
Expected page to load, it didn't

Exporting the palette, and re-importing, I get an invalid color error, and here's why:

  "coral": [
    "#2ebef",
    "#fce4e9",
    "#f8cdd8",
    "#f2a4be",
    "#e762a3",
    "#aa3e7e",
    "#72305d",
    "#492342",
    "#2d182c",
    "#140b16"
  ],

The first color in coral #2ebef is only 5 characters.

Screenshots
White screen

Environment

Safari (15.6.1)

Additional context

Just the specific color list (Coral) is corrupt, the other color lists for the group still work. I am not certain what I did to cause this, but I was working with linked curves IIR.

@lesliecdubs lesliecdubs added bug Something isn't working react labels Sep 20, 2023
@joshblack
Copy link
Member

Hi there! 👋

Thanks so much for taking the time to report this issue. We were trying to investigate the issue on our end but were unable to reproduce. We tried visiting the URLs that you linked but were never able to get it into a state where the hex color value was corrupted.

Do you still observe this behavior when clearing local storage and what not for the site? Is it also present for other versions of Safari or only in 15.6.1?

Thanks so much, appreciate any additional info here!

@Myndex
Copy link
Author

Myndex commented Sep 30, 2023

Hi @joshblack

Unfortunately, I can't find much additional. Trying to bring up scale:

.../scale/7b1f34cc-d9d9-4c03-84f3-208bc962b7f8

Causes the editing screen to quit, with console error:

Failed to load resource: the server responded with a status of 404 (Not Found)

And drops back to the home/gallery page (primer.style/prism/), though this is probably because it can not find a scale with the hash key 7b1f34c... and my local storage no longer seems to have that corrupted scale in it.

Sorry I don't have more for you at the moment, other than it's a cool tool, wish we could re-order the scales.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info react
Projects
None yet
Development

No branches or pull requests

3 participants