Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CheckboxGroup and RadioGroup components #830
base: main
Are you sure you want to change the base?
Add CheckboxGroup and RadioGroup components #830
Changes from 3 commits
885dd26
09ba756
50b888c
c3f881d
b71c4c2
e43f7fb
aca86dc
790fa13
526ae02
a9aca70
52cc180
810a183
d65b102
4b9b5f4
78366b2
7bd4fea
0fd5510
df783b5
fa4729d
17aefc5
8405890
3bbaec1
d3ab439
1aa22e8
8e91013
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Storybook provide a built-in type for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StoryObj
is the built-in, recommended type. See the example in the docs here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move this story into a separate
CheckboxGroup.features.stories.tsx
file and organize it inside aCheckboxGroup/Examples
orCheckboxGroup/Features
subfolder please? Probably former in this case as it's not a feature of the component.I know the other form control stories don't follow this format. It's because those predate the Primer ADR around story organization and also need to be updated at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think about my approach here
17aefc5
I wanted to keep the interactivity of the Inline story as it currently works nicely with the controls, but I didn't want to duplicate the controls set up (
args
,argTypes
) across both files, so I've brought themeta
object defined in the main story file into theexamples
file and reused it there, just with a modifiedtitle
.lmk if you're happy with this