Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let, function() assigment typos #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yildizib
Copy link

let changed var, for loop (of) changed (in), function assigment added and => removed

@SuperPat45
Copy link

This fix bug #281

Copy link

@SuperPat45 SuperPat45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing for of to for in require an additional check:
if (this.files.hasOwnProperty(sFile))

@@ -191,7 +191,7 @@
},

_isFileSelected: function(file) {
for(var sFile of this.files){
for(var sFile in this.files){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing for of to for in require an additional check:
if (this.files.hasOwnProperty(sFile))

var $this = this;

this._trigger('onBeforeUpload', null, {'xhr': xhr, 'formData': formData});

for(var file of this.files) {
for(var file in this.files) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing for of to for in require an additional check:
if (this.files.hasOwnProperty(file))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants