Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: filter IME Enter bug #7621

Open
CRC32EX opened this issue Jan 18, 2025 · 0 comments
Open

Dropdown: filter IME Enter bug #7621

CRC32EX opened this issue Jan 18, 2025 · 0 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@CRC32EX
Copy link

CRC32EX commented Jan 18, 2025

Describe the bug

Pressing the Enter key to confirm a converted word in the Japanese IME causes the filter dialog to close unexpectedly.

This problem happen on Remix.
Vite is no problem.

Reproducer

https://stackblitz.com/edit/remix-run-remix-9ccvms25

System Information

System:
  OS: Windows 11 10.0.22621
  CPU: (16) x64 AMD Ryzen 7 9800X3D 8-Core Processor
  Memory: 44.36 GB / 61.59 GB
Binaries:
  Node: 20.15.0 - C:\Program Files\nodejs\node.EXE
  npm: 10.7.0 - C:\Program Files\nodejs\npm.CMD
  pnpm: 9.14.2 - C:\Program Files\nodejs\pnpm.CMD
Browsers:
  Edge: Chromium (131.0.2903.51)
  Internet Explorer: 11.0.22621.3527

Steps to reproduce the behavior

  1. Click Dropdown
  2. type おんせん
  3. press space key (convert word)
  4. press enter key (confirm convert word)
  5. Dropdown closed unexpectedly.

Image

Expected behavior

  • Do not close Dropdown

Image

Possible solution

https://gist.github.com/CRC32EX/b05988bb96bf7910a25cad74f5a9c589/revisions

primereact/components/lib/dropdown/Dropdown.js

+ if (event.is_composing === false) {
+  onEnterKey(event);
+ }

Reference

@CRC32EX CRC32EX added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant