-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p-tabPanel does not detect changes when "disabled" binding is changed #9475
Comments
I'm having the same non-change-detection issue with basic properties like [header] and [leftIcon]. https://primeng-tabview-disbale-bug-qjzcja.stackblitz.io Windows 10/Chrome/Angular 11.02, PrimeNG Version 11.0.0-rc.1 |
Same issue here. headerStyleClass is not updating neither. I'd like to highlight tab with form validation errors, but it does not update: [headerStyleClass]="submitAttempted && form.get('basicInfo').invalid ? 'ng-dirty ng-invalid' : ''" I tried to use getter and put there console.log. The getter is called as usual and returns css classes as expected, but component does not update the header style. |
Hi, So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap? Best Regards, |
Hi Folks Could this issue be reopened please, we have the very same problem as described and have updated to the latest version of PrimeNG and its doesn't solve the problem. This is quite a major blocker for us Thanks |
primefaces#9475 getter/setter for header style changes should look into the rest of the properties
Hi, Couldn't replicate the issue with the latest PrimeNG. Here is the stackblitz example of the same code with the primeng v16.3.1: https://stackblitz.com/edit/mfhtwi?file=src%2Fapp%2Fdemo%2Ftab-view-disabled-demo.html,src%2Fapp%2Fdemo%2Ftab-view-disabled-demo.ts TabPanel works as expected, closing the issue. |
We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days. |
Hi, Please look up the follow-up bugs on this very same issue: #9475 (comment) It is still an issue, and it is a very important one for big forms. |
Demo on Stackblitz
https://stackblitz.com/edit/primeng-tabview-disbale-bug?file=src/app/app.component.html
Current behavior
When I change the [disabled] binding of a
p-tabPanel
component, the change is only detected when I click on the changed tab.Expected behavior
When I change the [disabled] binding of a
p-tabPanel
component, I expect the component to change to disabled/enabled state immediately.Please tell us about your environment:
OS: Windows 10
Browser: Chrome
Angular Version: 10.2.0
PrimeNG: Version 10.0.3
The text was updated successfully, but these errors were encountered: