Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By upgrade from [email protected] -> 19.0.2 expand/collapse table stopped working #17319

Closed
1 of 4 tasks
dzakicemir opened this issue Jan 7, 2025 · 3 comments
Closed
1 of 4 tasks
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dzakicemir
Copy link

dzakicemir commented Jan 7, 2025

Describe the bug

since the new version 19.0.2 row expansion is not working any more in my project.
You can see the same behavior on your story book homepage https://primeng.org/table#row-expansion
There is no action after clicking on expand image (beside toast-bar notification). Expand all /collapse all is also not working anymore

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://primeng.org/table#row-expansion

Environment

https://primeng.org/table#row-expansion

Angular version

19.0.2

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. go to https://primeng.org/table#row-expansion
  2. click on expand icon or expand all link

Expected behavior

Click on row-expand shall show details about the row

According to compare:
image

the new template name shall be #rowexpansion instead of #expandedrow but on your story book homepage it is still
image

and that could be the reason why the expand is not working on you side.

I have changed my template-reference-id to #rowexpansion and now is expand working again with the latest version 19.0.2 in my project.

@dzakicemir dzakicemir added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 7, 2025
@dzakicemir dzakicemir changed the title By upgrade from [email protected] -> 19.0.2 expand/colapse table stopped woking By upgrade from [email protected] -> 19.0.2 expand/collapse table stopped working Jan 7, 2025
@critchie
Copy link

critchie commented Jan 7, 2025

I opened #17306 regarding this same issue. Your template name change suggestion fixed it for me as well.

@dzakicemir
Copy link
Author

It seams only demo application is not updated. If you use proper template-reference-id "#rowexpansion" it works well (see above).

@critchie
Copy link

critchie commented Jan 7, 2025

That's how I see it. One of them (either the code or the documentation) needs to be addressed.

@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 8, 2025
@cetincakiroglu cetincakiroglu self-assigned this Jan 8, 2025
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 8, 2025
@cetincakiroglu cetincakiroglu added this to the 19.0.3 milestone Jan 8, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 8, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

3 participants