Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Designer Base Load Theme not allowing to choose a Theme file from the file system to customize it further #17318

Open
2 of 4 tasks
teshi24 opened this issue Jan 7, 2025 · 1 comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@teshi24
Copy link

teshi24 commented Jan 7, 2025

Describe the bug

When going to PrimeNG Theme Designer, Base, Load Theme and clicking on "Restore from local storage" button, I cannot chose a local theme file to upload and edit. Instead, sometimes it seem to adapt some variables, sometimes it seems to not do anything.

Same issue on V18. This is no issue which I can setup on stackblitz.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/github/primefaces/primeng-issue-template?file=src%2Fapp%2Fapp.component.html

Environment

Linux / Windows

Angular version

19.0.0

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. go to PrimeNG Theme Designer
  2. on Base, Load Theme clicking on "Restore from local storage" button

Expected behavior

  1. I can upload a ts file with the custom theme
  2. The values in the theme gets applied to the editor and can be viewed and edited, same as if it would be a Nora or other prepared theme.
  3. I can download the changes again
@teshi24 teshi24 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 7, 2025
@mertsincan
Copy link
Member

We're working new designer structure. We'll announce the details as soon as possible.

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 16, 2025
@mertsincan mertsincan added this to the 19.x milestone Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Review
Development

No branches or pull requests

2 participants