Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On focus in p-inputNumber it marks form dirty even value is unchanged #17169

Closed
1 of 4 tasks
dubey-suraj opened this issue Dec 21, 2024 · 0 comments · Fixed by #17213
Closed
1 of 4 tasks

On focus in p-inputNumber it marks form dirty even value is unchanged #17169

dubey-suraj opened this issue Dec 21, 2024 · 0 comments · Fixed by #17213
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@dubey-suraj
Copy link

dubey-suraj commented Dec 21, 2024

Describe the bug

I'm using p-inputNumber field and there is a validation that 'save' button should enable when form is dirty. Issue is when I click in p-InputNumber field and tabout or focus out it marks form as dirty even value is unchanged.

image

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-pteddaso?file=src%2Fapp%2Fapp.component.html

Environment

Angular 15, Vs code

Angular version

15.0.0

PrimeNG version

v18 (LTS Only)

Node version

No response

Browser(s)

chrome, edge

Steps to reproduce the behavior

  1. click on name input and click on "Save" it's disable because form is not dirty. It became dirty only when value changed.
  2. click on age than click "Save" button, it's enable now because form marked as dirty even value is not changed. this is the issue of primeNg.

Expected behavior

form should not mark as dirty until value gets changed. It should only be dirty when value get changed

@dubey-suraj dubey-suraj added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 21, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 25, 2024
@mertsincan mertsincan added this to the 19.0.2 milestone Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 25, 2024
mehmetcetin01140 added a commit that referenced this issue Dec 26, 2024
…y-onblur-bug

Fix: InputNumber(#17169) InputNumber marked dirty on blur
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants