Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra apostrophe in breadcrumb component #17148

Closed
KraftyKaleb opened this issue Dec 19, 2024 · 2 comments · Fixed by #17149
Closed

Extra apostrophe in breadcrumb component #17148

KraftyKaleb opened this issue Dec 19, 2024 · 2 comments · Fixed by #17149
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@KraftyKaleb
Copy link
Contributor

Describe the bug

Extra single quote/apostrophe character in breadcrumb (.p-breadcrumb-item-label) css class string. Viewable on line 104.

<span *ngIf="menuitem?.escape !== false; else htmlLabel" class="p-breadcrumb-item-label'">{{ menuitem?.label }}</span>

Environment

All environments. The code is viewable in git.

Reproducer

No response

Angular version

19.0.5

PrimeNG version

19.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.8.0

Browser(s)

No response

Steps to reproduce the behavior

View breadcrumb in chrome inspect element

Expected behavior

Css class to not have a random apostrophe

@KraftyKaleb KraftyKaleb added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 19, 2024
@martinkasa
Copy link

martinkasa commented Dec 20, 2024

Hi @KraftyKaleb, I noticed that the apostrophe is on four places, maybe you can update your PR to fix them all. Just search for string p-breadcrumb-item-label' to find them.

@KraftyKaleb
Copy link
Contributor Author

Hi @KraftyKaleb, I noticed that the apostrophe is on four places, maybe you can update your PR to fix them all. Just search for string p-breadcrumb-item-label' to find them.

Thank you, I have updated the PR accordingly.

@mertsincan mertsincan linked a pull request Dec 25, 2024 that will close this issue
@mertsincan mertsincan added this to the 19.0.2 milestone Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 25, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 25, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants