Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Regression: SelectButton roles (radio & checkbox) #17122

Open
c-o-l-i-n opened this issue Dec 18, 2024 · 0 comments
Open

Accessibility Regression: SelectButton roles (radio & checkbox) #17122

c-o-l-i-n opened this issue Dec 18, 2024 · 0 comments
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@c-o-l-i-n
Copy link
Contributor

c-o-l-i-n commented Dec 18, 2024

Describe the bug

In v17, the buttons in a single-selection SelectButton have role="radio", and the buttons in a multiple-selection SelectButton have role="checkbox". And when the buttons are selected, they have aria-checked="true".

However, in v18 and v19, the buttons have the implicit role button. And instead of aria-checked="true", they have aria-pressed="true".

Using the radio and checkbox roles makes sense because the user selects options like they would with a set of radio buttons or checkboxes.

v17: https://v17.primeng.org/selectbutton

v17 Select Button - Basic
v17 Select Button - Multiple

v19: https://primeng.org/selectbutton

v19 Select Button - Basic
v19 Select Button - Multiple

Steps to reproduce the behavior

Use the SelectButton component in PrimeNG v18 or v19.

Expected behavior

The buttons in a single-selection SelectButton component use role="radio" with aria-checked="true", and the buttons in a multiple-selection SelectButton component use role="checkbox" with aria-checked="true".

@c-o-l-i-n c-o-l-i-n added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 18, 2024
@mertsincan mertsincan added this to the 19.0.2 milestone Dec 19, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 19, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Review
Development

No branches or pull requests

2 participants