Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-input-number: typo in input number component content child incrementbuttonicon #17088

Closed
mariovyord opened this issue Dec 17, 2024 · 0 comments · Fixed by #17036
Closed

p-input-number: typo in input number component content child incrementbuttonicon #17088

mariovyord opened this issue Dec 17, 2024 · 0 comments · Fixed by #17036
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
18.0.1

Comments

@mariovyord
Copy link
Contributor

mariovyord commented Dec 17, 2024 •
edited
Loading

Describe the bug

The naming of the "incrementbuttonicon" content child has a typo:

Currently: "icrementbuttonicon"
Correct: "incrementbuttonicon"

Line 454 and 457 in packages/primeng/src/inputnumber/inputnumber.ts

Environment

NA

Reproducer

No response

Angular version

19.0.0

PrimeNG version

18.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@mariovyord mariovyord added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 17, 2024
@mariovyord mariovyord mentioned this issue Dec 17, 2024
Merged
@mertsincan mertsincan linked a pull request Dec 17, 2024 that will close this issue
fix (#17088): typo in input number component content child incrementbuttonicon #17036
Merged
@mertsincan mertsincan added this to the 18.0.1 milestone Dec 17, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 17, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 17, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
18.0.1
Development

Successfully merging a pull request may close this issue.

fix (#17088): typo in input number component content child incrementbuttonicon mariovyord/primeng
2 participants
@mertsincan @mariovyord