Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: toggle button is not rounded, missing p-button-rounded class #17080

Closed
TaneliTuomola opened this issue Dec 17, 2024 · 0 comments · Fixed by #17195
Closed

Panel: toggle button is not rounded, missing p-button-rounded class #17080

TaneliTuomola opened this issue Dec 17, 2024 · 0 comments · Fixed by #17195
Assignees
@mehmetcetin01140
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.2

Comments

@TaneliTuomola
Copy link

TaneliTuomola commented Dec 17, 2024 •
edited
Loading

Describe the bug

The panel component's toggle button should be round like in the primeVue library. The button is missing the p-button-rounded class.

PrimeNg
image
PrimeVue
image

Environment

https://primeng.org/panel#toggleable

Reproducer

https://primeng.org/panel#toggleable

Angular version

18.0.5

PrimeNG version

18.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.8.0.

Browser(s)

No response

Steps to reproduce the behavior

https://primeng.org/panel#toggleable

Expected behavior

https://primevue.org/panel/#toggleable
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 17, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 17, 2024
@mertsincan mertsincan added this to the 18.0.1 milestone Dec 17, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 17, 2024
@mehmetcetin01140 mehmetcetin01140 modified the milestones: 18.0.1, 19.0.1 Dec 17, 2024
@mertsincan mertsincan modified the milestones: 19.0.1, 19.0.2 Dec 19, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 24, 2024
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Dec 24, 2024
Merged
mehmetcetin01140 added a commit that referenced this issue Dec 24, 2024
@mehmetcetin01140
Merge pull request #17195 from primefaces/issue-17080
2c4ea29 
Fixed #17080 | Panel: toggle button is not rounded, missing p-button-…
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 24, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.2
Development

Successfully merging a pull request may close this issue.

Fixed #17080 | Panel: toggle button is not rounded, missing p-button-… primefaces/primeng
3 participants
@mertsincan @TaneliTuomola @mehmetcetin01140