Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-confirmDialog: style & styleClass are not being passed to confirm dialog [v19-rc1] #17072

Closed
imaksp opened this issue Dec 16, 2024 · 2 comments
Assignees
Milestone

Comments

@imaksp
Copy link

imaksp commented Dec 16, 2024

Describe the bug

confirm dialog is not passing style or custom class from styleClass (like max-w-xl) as shown in stackblitz.
see below image for example:

p-confirm-issue

Environment

NA

Reproducer

https://stackblitz.com/edit/stackblitz-starters-qstm28mv?file=src%2Fapp%2Fapp.component.html,src%2Fapp%2Fapp.component.ts

Angular version

19.x

PrimeNG version

19.0.0-rc1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.x

Browser(s)

ALL

Steps to reproduce the behavior

Check reproduction link , dialog uses full screen width if message has more characters.

Expected behavior

it should pass given style & styleClass to p-dialog.

@imaksp imaksp added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 16, 2024
@mertsincan mertsincan added this to the 19.0.0.Final milestone Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 16, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 16, 2024
@imaksp
Copy link
Author

imaksp commented Dec 17, 2024

Hi, I have checked code for this, it seems passed styleClass value is not being used in component, instead it uses cx('root'):

& it seems style prop is not even present on p-dialog used inside p-confirmDialog:

<p-dialog
#dialog
[(visible)]="visible"
role="alertdialog"
[closable]="option('closable')"
[styleClass]="cx('root')"
[modal]="true"
[header]="option('header')"
[closeOnEscape]="option('closeOnEscape')"
[blockScroll]="option('blockScroll')"
[appendTo]="option('appendTo')"
[position]="position"
>
@if (headlessTemplate) {

cetincakiroglu added a commit that referenced this issue Dec 17, 2024
@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 17, 2024
@cetincakiroglu cetincakiroglu self-assigned this Dec 17, 2024
@cetincakiroglu
Copy link
Contributor

fixed in 5a4219a

@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants