Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic dialog: header text is bugged #16666

Closed
MykolaSirko1 opened this issue Oct 30, 2024 · 2 comments
Closed

Dynamic dialog: header text is bugged #16666

MykolaSirko1 opened this issue Oct 30, 2024 · 2 comments
Assignees
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Milestone

Comments

@MykolaSirko1
Copy link

Describe the bug

I am using DialogService to open my component:

onModal() {
    this.dialogService.open(ModalComponent, {
      header: 'Modal header',
      width: '500px',
      style: { background: 'transparent' },
      modal: true,
      closable: true,
    });
  }

the problem is when option closable: true is added, then when the modal window is opened for the first time, the following text is displayed in the header instead of what is specified in the options:
image

On subsequent openings, the text becomes correct:

image

Environment

Development

Reproducer

No response

Angular version

18.2.3

PrimeNG version

18.0.0-beta.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Header text is correct

@MykolaSirko1 MykolaSirko1 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 30, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan added this to the 18.0.0-rc.2 milestone Nov 19, 2024
@mertsincan mertsincan removed this from PrimeNG Nov 20, 2024
@mehmetcetin01140 mehmetcetin01140 added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Nov 25, 2024
Copy link

We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days.

@mehmetcetin01140 mehmetcetin01140 closed this as completed by moving to Done in PrimeNG Nov 25, 2024
@Zeck-Koay
Copy link

Zeck-Koay commented Nov 28, 2024

Hi, I created example based on the Issue Template.
https://stackblitz.com/edit/github-sqieue

Edited:
Adding info for this example.
PrimeNG version: 18.0.0-rc.1

Tested using this example in Window 10 & 11, Chromium (Chrome and Edge) and Firefox, latest version by today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Projects
Status: Done
Development

No branches or pull requests

4 participants