Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Drawer does not render footer template #16641

Closed
adamlwomble opened this issue Oct 25, 2024 · 1 comment
Closed

Component: Drawer does not render footer template #16641

adamlwomble opened this issue Oct 25, 2024 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@adamlwomble
Copy link

Describe the bug

The Drawer component does not display the footer template; looking at its source, the template appears to be the problem because it references _footerTemplate (lines 90 and 92) where the component class declares the property as footerTemplate (line 293).

Environment

macOS Sequoia 15.0.1
Unix shell (Zsh)

Reproducer

No response

Angular version

~18.2.0

PrimeNG version

18.0.0-beta.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.18.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Implement an instance of the Drawer component
  2. Within the <p-drawer> opening and closing tags, include <ng-template pTemplate="footer">Footer</ng-template>
  3. Verify the text “Footer” is neither displayed in the view nor rendered in the DOM.

Expected behavior

  1. Implement an instance of the Drawer component
  2. Within the <p-drawer> opening and closing tags, include <ng-template pTemplate="footer">Footer</ng-template>
  3. Verify the text “Footer” is both displayed in the view and rendered in the DOM.
@adamlwomble adamlwomble added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 25, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone Oct 26, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks a lot for testing the beta and giving us feedback. This issue is fixed in 57adb2b

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 7, 2024
@cetincakiroglu cetincakiroglu self-assigned this Nov 7, 2024
@mertsincan mertsincan modified the milestones: 18.0.0-rc.1, 18.0.0-beta.4 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants