Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Table (p-table) #16631

Open
Mariobahaa opened this issue Oct 24, 2024 · 2 comments
Open

Component: Table (p-table) #16631

Mariobahaa opened this issue Oct 24, 2024 · 2 comments
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback Resolution: Needs Upvote 👍 Support this idea or feature by adding an upvote. Community feedback helps with prioritization.
Milestone

Comments

@Mariobahaa
Copy link

Describe the bug

Hello, I'm using p-table with expandable row groups and virtual scrolling.
if the number of group headers can't fit within the virtual scroll height initially, as you scroll down each single row data is wrapped in a separate expandable group header.
when this grouped header (wrapping only one row data) is collapsed, if there are similar group headers they are also collapsed and sometimes a white space is left in the table with no-use.

I have been able to reproduce in stackblitz: https://stackblitz.com/edit/qlahmk-aruxie?file=src%2Fapp%2Ftable-expandable-row-group-demo.html
Please try to fix this as it is a bottle-neck trying to create high-performance tables having expandable group headers

Screenshot (522)

Environment

on Stackblitz
primeng: v17.18.11
node: v18.20.3
angular cli: v18.2.0

also able to reproduce for older primeng versions, node versions and angular cli versions

Reproducer

https://stackblitz.com/edit/qlahmk-aruxie?file=src%2Fapp%2Ftable-expandable-row-group-demo.html

Angular version

18.2.0

PrimeNG version

17.18.11

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

No response

Steps to reproduce the behavior

  1. Create a table with virtual scrolling and expandable row groups with a virtual scroll height the won't fit all of the rows and row groups
  2. Move to the table and scroll down within
  3. View the corrupted data and duplicated row group headers
  4. Expand some of the duplicated row group headers
  5. Collapse one the duplicated row group headers
  6. View all group headers collapsing (white spaces may occur sometimes)

Expected behavior

Should be able to use virtual scrolling with expandable grouped headers freely.
When I scroll down I should be able to see rows grouped together with a unique group header
When I collapse a group header, Only the one I collapsed should be collapsed

@Mariobahaa Mariobahaa added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 24, 2024
@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback Resolution: Needs Upvote 👍 Support this idea or feature by adding an upvote. Community feedback helps with prioritization. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan added this to the Future milestone Nov 19, 2024
Copy link

Thanks a lot for this issue! PrimeNG team's roadmap is busy, but community feedback is crucial in prioritization. The more upvotes help ensure this fix can be addressed quickly or the related PR can be merged soon.

Copy link

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback Resolution: Needs Upvote 👍 Support this idea or feature by adding an upvote. Community feedback helps with prioritization.
Projects
Status: Review
Development

No branches or pull requests

2 participants