Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pFocusTrap for columnFilter menu #16616

Open
CopilotHeb opened this issue Oct 23, 2024 · 1 comment
Open

pFocusTrap for columnFilter menu #16616

CopilotHeb opened this issue Oct 23, 2024 · 1 comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@CopilotHeb
Copy link

Describe the bug

The pFocusTrap does not work for the p-columnFilter filter menu.

Environment

Stackblitz

Reproducer

https://stackblitz.com/run?file=src%2Fapp%2Ftable-filter-advanced-demo.html

Angular version

18.2.2

PrimeNG version

17.18.11

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.12.2

Browser(s)

Chrome

Steps to reproduce the behavior

Go to the primeNG filter demo on stackblitz: See: https://stackblitz.com/run?file=src%2Fapp%2Ftable-filter-advanced-demo.html

  • Open one of the table filter menues
  • Navigate with tab-key to the last control (i.e. apply button)
  • The after the next 'tab' the menu is still be open, but the focus is in the browser address bar instead of the first control in the filter menu

Expected behavior

The focus should stay in the filter menu if the pFocusTrap directive was applied to the p-columnFilter.

@CopilotHeb CopilotHeb added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 23, 2024
@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
Copy link

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

@mertsincan mertsincan added this to the 17.18.13 milestone Nov 19, 2024
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 19, 2024
@mertsincan mertsincan modified the milestones: 17.18.13, 17.x Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: No status
Development

No branches or pull requests

2 participants