Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New directives | pButtonLabel & pButtonIcon #16589

Closed
cetincakiroglu opened this issue Oct 18, 2024 · 0 comments
Closed

New directives | pButtonLabel & pButtonIcon #16589

cetincakiroglu opened this issue Oct 18, 2024 · 0 comments
Assignees
@cetincakiroglu
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request
Milestone
18.0.0-rc.1

Comments

@cetincakiroglu
Copy link
Contributor

Two new directives will be introduced to use along with pButton directive.
When pButton is used, the directive generates the label and icon in a hardcoded way. Instead, we'll introduce pButtonLabel and pButtonIcon to make it easier to customize.
@cetincakiroglu cetincakiroglu added the Type: New Feature Issue contains a new feature or new component request label Oct 18, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone Oct 18, 2024
@cetincakiroglu cetincakiroglu self-assigned this Oct 18, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 18, 2024
cetincakiroglu added a commit that referenced this issue Oct 19, 2024
@cetincakiroglu
Add pButtonLabel & pButtonIcon directives, fixes #16589
73fab54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
18.0.0-rc.1
Development

No branches or pull requests
1 participant
@cetincakiroglu