Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P-Table: Virtual scroll + filter (empty) error #16587

Open
AlexFHer opened this issue Oct 18, 2024 · 3 comments
Open

P-Table: Virtual scroll + filter (empty) error #16587

AlexFHer opened this issue Oct 18, 2024 · 3 comments
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@AlexFHer
Copy link

Describe the bug

When a table is created with virtual scroll and filter at the same time it works fine until the filter does not match any value

The table just explodes and even if you change the filter it wont go back to normal, seems like the height is not being calculated correctly afterwards...

here is an example from stackblitz using the table virtual scroll and just adding the filter:

https://stackblitz.com/edit/vsn2ph?file=src%2Fapp%2Ftable-virtual-scroll-demo.html,src%2Fservice%2Fcarservice.ts

Environment

Prime ng 17.18.11
Windows 11
Chrome

Showcase in stackblitz.

Reproducer

No response

Angular version

18.0.1

PrimeNG version

17.18.11

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v20.17.0

Browser(s)

Chrome

Steps to reproduce the behavior

Repro steps

  1. Create table with virtual scroll
  2. Add filtering
  3. type something in filter it does not exist in the data so 0 ocurrences are found

Expected behavior

If the filter changes it should show the data

@AlexFHer AlexFHer added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 18, 2024
@nishtha9102
Copy link

Hi can i be assigned this @AlexFHer

@AlexFHer
Copy link
Author

Sure, thanks!

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Nov 19, 2024
@mertsincan mertsincan modified the milestones: 17.18.13, 17.x Dec 9, 2024
@JCarusWTW
Copy link

Hi - I'm confused by this. The stackblitz shared doesn't seem to successfully filter for me at all, even when e.g. adding 1 into the ID filter. I came across this issue when trying to work out how to get virtual scroll and filter to work together, but it looks like even in the situation you're saying it DOES work, the stackblitz doesn't.

Can anyone shed any light? Very happy to be told I'm missing something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: No status
Development

No branches or pull requests

4 participants