v18 p-columnFilter: Column filtering indicator is missing

[rosenthalj]

Describe the bug

In PrimeNG v18 when a table column is filtered using the p-columnFilter component there is no indication of filtering in the corresponding table column header.

Note: When viewing the screenshots listed below and the videos listed below, you may want to use "full screen mode", because the "highlighting" of the background colors of the v17 filter icons buttons can be hard to see.

The following screenshot compares the "correct" v17 filter table demo after filtering vs "incorrect" v18 filter table demo after filtering:

The following screenshot compares the style of the filtered name button element for v17 and v18

The following video shows the v17 Table Advanced Filter demo "indicating" that column filters are set

v17TableColumnFilterWorking.mov

The following video shows the v18 Table Advanced Filter demo "not indicating" that column filters are set

v18TableColumnFilterBug.mov

Environment

n/a

Reproducer

https://v18.primeng.org/table#filter-advanced

Angular version

18.x

PrimeNG version

18.0.0.beta-3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

n/a

Browser(s)

chrome, firefox, safari

Steps to reproduce the behavior

1. Run the v18 Table Filter Advance Demo: https://v18.primeng.org/table#filter-advanced
2. Filter for one or more columns
   --- After the table is filtered there will be no indications in the table that any of the filters have been set (bad)

Expected behavior

When a column filter is set the corresponding column filter has a visual indication that it has been set.

I.e. v18 column filter set indicating functionality should work similarly to the current v17 functionality

[cagataycivici]

It seems to be missing yes but we can't add a new token right now due to RC stage, it'll be fixed in v18.1.0. Also an issue in PrimeVue which should be fixed in v4.3.0.

[shaman-apprentice]

It seems to be missing yes but we can't add a new token right now due to RC stage, it'll be fixed in v18.1.0. Also an issue in PrimeVue which should be fixed in v4.3.0.

From my point of view, there is nothing to be said against adding a new feature (token) with a reasonable default to a RC. Shouldn't break anything, so why not? Of course, it is your call to make 👍