Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password: Tab navigation not getting focussed on Eye icon in ToggleMask Mode. #16555

Closed
akshayaqburst opened this issue Oct 16, 2024 · 0 comments · Fixed by #16556
Closed

Password: Tab navigation not getting focussed on Eye icon in ToggleMask Mode. #16555

akshayaqburst opened this issue Oct 16, 2024 · 0 comments · Fixed by #16556
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.18.13

Comments

@akshayaqburst
Copy link
Contributor

Describe the bug

Password: Tab navigation not getting focussed on Eye icon in ToggleMask Mode.

Environment

System:
OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
Memory: 1.70 GB / 7.47 GB
Container: Yes
Shell: 5.0.17 - /bin/bash
Binaries:
Node: 20.5.0 - ~/.nvm/versions/node/v20.5.0/bin/node
npm: 9.8.0 - ~/.nvm/versions/node/v20.5.0/bin/npm

Reproducer

https://primeng.org/password#togglemask

Angular version

17.x.x

PrimeNG version

17.18.11

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.5.0

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Go to https://primeng.org/password#togglemask
  2. Enter something
  3. Press tab key, the focus moves to a different section of the page.

Expected behavior

The focus should move to the eye icon and pressing enter key should toggle the Input.
@akshayaqburst akshayaqburst added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 16, 2024
akshayaqburst pushed a commit to qburst/primeng_qb_8 that referenced this issue Oct 16, 2024
fix: primefaces#16555, Password: Tab navigation not getting focussed …
61461c2 
…on Eye icon in ToggleMask Mode.
@akshayaqburst akshayaqburst mentioned this issue Oct 16, 2024
Merged
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 18, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Nov 18, 2024
mertsincan pushed a commit that referenced this issue Dec 6, 2024
@akshayaqburst
fix: #16555, Password: Tab navigation not getting focussed on Eye ico…
807fa64 
…n in ToggleMask Mode. (#16556)

Co-authored-by: ANTONA09 <[email protected]>
@github-project-automation github-project-automation bot moved this to Done in PrimeNG Dec 6, 2024
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
PrimeNG
Status: Done
Milestone
17.18.13
2 participants
@mertsincan @akshayaqburst