Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primeicons.ts icon missing and wrong icons key #16543

Closed
Mundi93 opened this issue Oct 14, 2024 · 0 comments · Fixed by #16544
Closed

Primeicons.ts icon missing and wrong icons key #16543

Mundi93 opened this issue Oct 14, 2024 · 0 comments · Fixed by #16544
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port
Milestone
17.18.13

Comments

@Mundi93
Copy link
Contributor

Mundi93 commented Oct 14, 2024

Describe the bug

I noticed a bug in primeiconts.ts

  • ASTERIKS = 'pi pi-asteriks' is wrong, should be ASTERISK = 'pi pi-asterisk' here

The next ones are not real bugs, but suggestions for a more intuitive use:

  • ARROW_H = 'pi pi-arrows-h' the key would be better if it were ARROWS_H' to better fit the value here
  • ARROW_V = 'pi pi-arrows-v' the key would be better if it were ARROWS_V' to better fit the value; here

Environment

N/A

Reproducer

No response

Angular version

18.0.1

PrimeNG version

17.18.11

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.9.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Mundi93 Mundi93 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 14, 2024
@Mundi93 Mundi93 mentioned this issue Oct 14, 2024
Merged
@mertsincan mertsincan added this to the 17.18.13 milestone Nov 18, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 18, 2024
@mertsincan mertsincan linked a pull request Nov 18, 2024 that will close this issue
Asterisk icon wrong key and value; arrow-h and arrow-v wrong key #16544
Merged
mehmetcetin01140 added a commit that referenced this issue Nov 28, 2024
@mehmetcetin01140
Fixed #16543 | Primeicons.ts icon missing and wrong icons key
96e4d00
@mertsincan mertsincan moved this to Done in PrimeNG Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port
Projects
PrimeNG
Status: Done
Milestone
17.18.13
Development

Successfully merging a pull request may close this issue.

Asterisk icon wrong key and value; arrow-h and arrow-v wrong key Mundi93/primeng
2 participants
@mertsincan @Mundi93