Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: Can't close tab when ripple is enabled (on v18) #16521

Closed
mikype-nice opened this issue Oct 11, 2024 · 1 comment
Closed

Tabs: Can't close tab when ripple is enabled (on v18) #16521

mikype-nice opened this issue Oct 11, 2024 · 1 comment
Assignees
@cetincakiroglu

Comments

@mikype-nice
Copy link

mikype-nice commented Oct 11, 2024 •
edited
Loading

Describe the bug

When both closable tabs and the ripple effect are enabled, the X button cannot be used to close the tab.
You can see it in the v18 tabs demo page.

Environment

Arc Browser, MacOS Sonoma

Reproducer

No response

Angular version

18.0.0

PrimeNG version

18.0.0-beta.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.0.0

Browser(s)

Arc

Steps to reproduce the behavior

No response

Expected behavior

No response
@mikype-nice mikype-nice added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 11, 2024
wS2Zth added a commit to wS2Zth/primeng that referenced this issue Oct 12, 2024
@wS2Zth
fix(tabs): fix issue primefaces#16521 - close button not working with…
d71095f 
… ripple effect
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone Oct 26, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan removed this from PrimeNG Nov 20, 2024
@cetincakiroglu cetincakiroglu self-assigned this Nov 21, 2024
@mertsincan mertsincan modified the milestones: 18.0.0-rc.2, 18.0.0.Final Nov 26, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

Tabs component has been reworked and closable property has been removed. You don't need to use it anymore with the new structure. Closing the issue.

@github-project-automation github-project-automation bot moved this to Done in PrimeNG Dec 3, 2024
@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 3, 2024
@cetincakiroglu cetincakiroglu removed this from the 18.0.0.Final milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
None yet
Projects
PrimeNG
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mertsincan @cetincakiroglu @mikype-nice