Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Table responsiveLayout="stack" doesn't work since v17.8.9 #16510

Open
zlatanov opened this issue Oct 9, 2024 · 15 comments
Open

Component: Table responsiveLayout="stack" doesn't work since v17.8.9 #16510

zlatanov opened this issue Oct 9, 2024 · 15 comments
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@zlatanov
Copy link

zlatanov commented Oct 9, 2024

Describe the bug

Setting reponsiveLayout to "stack" doesn't work in 17.18.9. It works with 17.18.8. I suspect that this PR #16210 is the culprit.

17.18.8...17.18.9.

Check the demos - https://primeng.org/table#responsive-stack, it doesn't work also.

Environment

Windows 11

Reproducer

No response

Angular version

18.2.6

PrimeNG version

17.18.9

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10.0

Browser(s)

Edge

Steps to reproduce the behavior

Open https://primeng.org/table#responsive-stack

Expected behavior

The table should be rendered correctly.

@zlatanov zlatanov added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 9, 2024
@imaksp
Copy link
Contributor

imaksp commented Oct 11, 2024

Hi this could be issue with v17.18.9+ as you mentioned, but its deprecated in v18 & only scroll is supported, so if you use this option , you won't be able to upgrade.

@zlatanov
Copy link
Author

Hi this could be issue with v17.18.9+ as you mentioned, but its deprecated in v18 & only scroll is supported, so if you use this option , you won't be able to upgrade.

Where can I read about its deprecation?

@imaksp
Copy link
Contributor

imaksp commented Oct 16, 2024

Hi, you can check it here:
https://v18.primeng.org/table#api.table.props.responsive

it says table is now always responsive with scroll behaviour.

@zlatanov
Copy link
Author

zlatanov commented Oct 16, 2024 via email

@imaksp
Copy link
Contributor

imaksp commented Oct 16, 2024

Ok, that property is present I missed it, but its still not available in v18 demo, may be demo needs to be updated.
https://v18.primeng.org/table

@m4n50n
Copy link

m4n50n commented Oct 26, 2024

Same problem here. So, am I forced to upgrade to Angular / PrimeNG 18?

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan added this to the 19.x milestone Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 25, 2024
@VicTMPDeV
Copy link

in my case, i'm using new version 19 and responsiveLayout="stack" has been fixed and it works

@m4n50n
Copy link

m4n50n commented Jan 8, 2025

This new version looks like a different library. It gives the feeling that they don't care about projects that use older versions. If you're still on v16-17, you're starting to get really screwed.

@imaksp
Copy link
Contributor

imaksp commented Jan 8, 2025

Hi @m4n50n they provide LTS version for that, but its paid, current v17 LTS version is 17.18.16-lts. it also comes with premium support you can get that if you can't update to the latest.

@ChrisRitchie
Copy link

This new version looks like a different library. It gives the feeling that they don't care about projects that use older versions. If you're still on v16-17, you're starting to get really screwed.

I have sunk days into fixing a large code base after upgrading to v18. Ive been using Primeng for years, and this release has just caused countless issues. Hours restyling, component name changes, various bugs, its been a nightmare

@epitzalis
Copy link

epitzalis commented Jan 9, 2025

I think the same, I think it's a very bad decision by Prime NG. A disappointment and I will never recommend Prime NG again. I'm just reding everyone's discontent, and rightly so.

@VicTMPDeV
Copy link

Hi this could be issue with v17.18.9+ as you mentioned, but its deprecated in v18 & only scroll is supported, so if you use this option , you won't be able to upgrade.

Is the responsiveLayout="stack" gonna be deprecated? it wasn't working since 17.18 but in 19 is fixed and works properly. Please, don't remove this feature. This kind of table UI for mobile is very usefull.

@imaksp
Copy link
Contributor

imaksp commented Jan 9, 2025

Hi @VicTMPDeV , no it was my misunderstanding that prop is still present here:
https://primeng.org/table#api.table.props.responsiveLayout

but demo site needs to be updated, without demo most new users won't notice this feature.

@VicTMPDeV
Copy link

Hi @imaksp , thanks for your fast response.
I'm a little bit afraid about this, because your partner @mertsincan has said in another issue that is gonna be removed (for primeVue, right? but i'm sure that you'll apply the same roadmap for all your products and i want to be sure for that, because it strikes on our app core).
This is the thread I was talking about with the info provided by @mertsincan :

primefaces/primevue#3682

@imaksp
Copy link
Contributor

imaksp commented Jan 9, 2025

Hi @VicTMPDeV I am not associated with official team, I didn't knew that it was deprecated & later removed from PrimeVue. someone from official team could answer this in better way. they might remove if it gets difficult to support with new features.
Personally I think for simple table like layout, table can be replaced with css grid to support such layout on small device.

@mertsincan mertsincan modified the milestones: 19.x, 19.1.0 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Review
Development

No branches or pull requests

8 participants