Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18.0.0-beta2 - ComponentStyles are not exported -> extended Components fail #16509

Closed
DbkMG opened this issue Oct 9, 2024 · 1 comment
Closed

18.0.0-beta2 - ComponentStyles are not exported -> extended Components fail #16509

DbkMG opened this issue Oct 9, 2024 · 1 comment
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
18.0.0-beta.3

Comments

@DbkMG
Copy link

DbkMG commented Oct 9, 2024

Describe the bug

We extend some PrimeNG-Components and while testing the 18.0.0-beta.2 release we get RuntimeErrors because the component-styles are not provided.

We can't provide them ourself because they are not exported via public_api.

Environment

ng 18
primeng 18.0.0-beta.2

Reproducer

No response

Angular version

18.2.6

PrimeNG version

18.0.0-beta.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@DbkMG DbkMG added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 9, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-beta.3 milestone Oct 11, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 13, 2024
@cetincakiroglu cetincakiroglu self-assigned this Oct 13, 2024
cetincakiroglu added a commit that referenced this issue Oct 14, 2024
@cetincakiroglu
Add missing theming exports, fixes #16509
16c99c8
@cetincakiroglu
Copy link
Contributor

Fixed in 16c99c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
18.0.0-beta.3
Development

No branches or pull requests
2 participants
@cetincakiroglu @DbkMG